Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jesus to People section #265

Merged
merged 3 commits into from
Jun 10, 2024
Merged

Add Jesus to People section #265

merged 3 commits into from
Jun 10, 2024

Conversation

monoguitari
Copy link
Contributor

feat: added jesus data to yaml and main/hover images to image directory

@monoguitari monoguitari requested review from eldu and galenwinsor June 9, 2024 18:57
@monoguitari monoguitari closed this Jun 9, 2024
@monoguitari monoguitari reopened this Jun 9, 2024
Copy link

github-actions bot commented Jun 9, 2024

Visit the preview URL for this PR (updated for commit e8e3ecb):

https://ccv-brown-edu--pr265-add-jesus-to-website-lgsx9fts.web.app

(expires Mon, 17 Jun 2024 16:11:39 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e6225babbaf68dadb99b2906d33811740e5d15cb

@monoguitari
Copy link
Contributor Author

Fails preview-on-pr / build_and_preview (pull_request) but I can see myself with https://ccv-brown-edu--pr265-add-jesus-to-website-lgsx9fts.web.app/about#people. Not sure what error means here, but this suggests it should be safe to ignore. (not sure if this is a google-query or firebase thing though)

Copy link
Contributor

@galenwinsor galenwinsor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm gonna go ahead and approve this, not sure what the error is either!

@monoguitari monoguitari merged commit a37ef2b into main Jun 10, 2024
12 checks passed
@monoguitari monoguitari deleted the add-jesus-to-website branch June 10, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants